Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fullPath on methods. #1200

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Conversation

dcr-stripe
Copy link
Contributor

Notify

r? @richardm-stripe

Summary

Adds support for fullPath to StripeMethod, letting methods specify a full path (ie. a path that is not a suffix of the resource base).

This is necessary for search URLs and in the future we plan on migrating all methods to this, removing some of the URL magic behind the scenes.

Test plan

Added unit tests.

};

let actualPath;
const mockSelf = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@dcr-stripe dcr-stripe merged commit 604d2ec into master Jul 28, 2021
@dcr-stripe dcr-stripe deleted the dcr-full-path-support branch July 28, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants